Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to reserve instance names and provide + reserve definition names #86

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

mkorbel1
Copy link
Contributor

@mkorbel1 mkorbel1 commented Mar 7, 2022

Description & Motivation

  • There are some situations where it is desirable for Module instance names to be fixed and not uniquified. A new flag in Module provides the ability to prevent an instance name from being uniquified.
  • There are some situations where it is desirable for Module definition names to be set in generated output. A new String parameter enables users to specify the desired definition name. It can be reserved as well via flag, similar to the new capability for instance names.

Related Issue(s)

N/A

Testing

Added new tests for new capabilities.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

API doc comments updated

@mkorbel1 mkorbel1 merged commit c8b52f1 into intel:main Mar 7, 2022
@mkorbel1 mkorbel1 deleted the defname branch March 7, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant