Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: no dpc if windows debug #1767

Merged
merged 1 commit into from
Mar 19, 2024
Merged

FIX: no dpc if windows debug #1767

merged 1 commit into from
Mar 19, 2024

Conversation

ethanglaser
Copy link
Contributor

@ethanglaser ethanglaser commented Mar 18, 2024 •
edited
Loading

Description

Do not build sklearnex dpc/spmd libs if in using windows debug - onedal dpc libs not built. Should resolve fail in build step of sklearnex windows in debug jobs.

@ethanglaser
Copy link
Contributor Author

ethanglaser commented Mar 18, 2024 •
edited
Loading

Debug job with changes: http://intel-ci.intel.com/eee55e4f-8bea-f143-8cf1-a4bf010d0e2e (green windows CI, previously had build failures)

@ethanglaser
Copy link
Contributor Author

/intelci: run

@md-shafiul-alam
Copy link
Contributor

looks good to me. Interesting that we build daal4py on nightly debug jobs but do not run any sklearnex tests. Are they out of scope for these debug jobs? Or were they disabled because of failures in the build steps?

@ethanglaser
Copy link
Contributor Author

looks good to me. Interesting that we build daal4py on nightly debug jobs but do not run any sklearnex tests. Are they out of scope for these debug jobs? Or were they disabled because of failures in the build steps?

Good question - no idea about the answer but it does seem odd, my only thought is that debug build is only useful for C++ testing. @homksei is there any benefit to running the sklearnex tests with debug build?

@ethanglaser ethanglaser merged commit ecfc317 into intel:main Mar 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@md-shafiul-alam md-shafiul-alam md-shafiul-alam approved these changes

@napetrov napetrov Awaiting requested review from napetrov napetrov is a code owner

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@samir-nasibli samir-nasibli Awaiting requested review from samir-nasibli samir-nasibli is a code owner

@homksei homksei Awaiting requested review from homksei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanglaser @md-shafiul-alam