-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vfNames in selectors to support VM case #205
Comments
@pperiyasamy thanks for trying to address dpdk usage in VM in another way. It sounds to me that VfName may not reflect the fact that it's going to use VF PCI address as element of VfNames, Wrt supporting netdevice with this same VfName selector, it reminds me of When DP is enabled to support VF device in VM, we may also need to consider improving SR-IOV CNI in order to use VF in kernel mode inside VM. Which I don't think it works today. For example, it still needs to access PF when configuring VF. The ability to configure VF properties (such as vlan, spoof check, trusted vf) is not available inside OpenStack VM unless it has a way to communicate with Neutron. |
@zshi-redhat Thanks for your feedback. The
Yes, It needed changes. I will work on it. |
Yes, it does look similar to
|
@zshi-redhat I've updated PR #195 as per the discussion. Please have a look and let me know. |
@pperiyasamy thanks for the quick implementation! |
@ahalim-intel PTAL, thanks! |
Should this issue be closed as I believe that #195 deals with it and has been merged? |
Yes, closing it. |
What would you like to be added?
I would like to provide vfNames field in selectors to enumerate matched devices into resource pool.
What is the use case for this feature / enhancement?
In case of OpenStack VM deployments, the virtio (or) VFs interfaces are created and attached inside the VM for applications usage. These devices can be either bound with net or dpdk driver.
When dpdk driver is bound with those devices, then there won’t be any kernel interface associated with it and can’t be mapped into a resource pool using its PCI Address in pfNames parameter. so it needs vfNames parameter to filter the devices at granular level.
The vfNames is provided with list of PCI Addresses of such devices.
It can be also made to support net devices.
The text was updated successfully, but these errors were encountered: