-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pciAddresses selectors for VM usecase #195
Conversation
Hi @pperiyasamy thanks for your PR! |
@zshi-redhat Yes, this is for the use case where PF is not accessible and left/right VF (or virtio) devices having same vendor and device id. hence we need to enumerate using their names to create left and right resource pools. |
From current implemention of |
@zshi-redhat There is no interface name associated with the VF/virtio device bound with dpdk driver. so no net directory. isn't it ? |
@zshi-redhat any update on this ? |
I think we probably don't want to use PCI address as a fake PF name. It might be good to come up a solution to support using DP in VM instead of having small fixes for each use case. |
Okay, Can we properly fix it by adding vfNames in selectors? Here is the issue #205 |
418f4d6
to
2692a05
Compare
135465e
to
753644c
Compare
HI zshi, do you have any new ideas on this PR? We also need this filter to support VM case, any update for the moment? |
@lynic I'm still hoping to rework on this PR depending on feedback here. |
@pperiyasamy I think a selector for device pci address is desirable and possbly address the VM usecases. Let's come up with more meaningful parameter name instead of "vfDevices". This selector could be applied for any pci devices -regardless of VF or PF. Could you please update this PR? |
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
@ahalim-intel Thanks for your attention now, updated the PR replacing "vfDevices" parameter with "pciAddresses". Hope this is more relevant and generic. |
might be worth updating the readme file. |
@zshi-redhat Thanks, will update the readme. I just noticed |
Yes, this selector should be common and go in |
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Hi, addressed the comments on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
updated commit header |
This PR looks ready to be merged, is there any plan to get it in? |
This makes device plugin to support VM usecase in which
vf (or) virtio devices can be enumerated into a device
pool using its pci addresses.
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech