This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Net single tcp packet #1522
Merged
Net single tcp packet #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful so you can make sure your sample flashed correctly and you're running the sample you think you are. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
This patch renames the control flag for the code that records the file and function that signalled a callback to INSTRUMENT_CALLBACKS. This lets you easily turn it on or off instead of tying it to DEBUG_BUILD. I just encountered a bug where I get a segfault on K64F with DEBUG_BUILD; turning this feature off fixes it so that's what I'm going to do for now. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Because we defer the handling of new connections, it's possible for the new connection socket to be closed before we handle the first data packet, or even before we get around to accepting the new connection. The correct thing to do in this case is to still report the new connection, and report the data received, but mark the socket as closed so we don't allow writing to it. Then once the connection and data have been report it, we issue a close event. To do this, we register the server handle, not the socket handle, with tcp_received, and then look up the socket based on the context the packet came in on. So we also had to do that for the client sockets, for which we added a "no_server" stub handle. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
|
Fixes #1512 |
This was referenced Sep 7, 2017
grgustaf
force-pushed
the
net-single-tcp-packet
branch
from
d8689ac to
49403eb
Compare
There was no reason to keep them around since the functions inside were no longer held; this only exacerbated memory leak problems. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Because this was still a deferred emit while receive_packet and clear_closed were using immediate emits, the 'connection' event would end up happening *after* the 'data' and 'close' events, so there was no one signed up to hear them. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Does nothing in release mode, but in debug mode if an assertion fails it prints a message and hangs to make sure it's noticed. Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
|
LGTM +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.