Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Adds large tests #18

Merged
merged 1 commit into from
Sep 15, 2016
Merged

Adds large tests #18

merged 1 commit into from
Sep 15, 2016

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Sep 14, 2016

Summary of changes:

  • Adds large tests and example that runs in docker-compose/kubernetes.
  • Adds README for examples/tasks and scripts.

How to verify it:

  • Pull branch and run tests via commands below.

Testing done:

  • make test-large
  • TEST_K8s=1 make test-large

A picture of a snapping turtle (not required but encouraged):
snapping-turtle

@intelsdi-x/plugin-maintainers

@kindermoumoute
Copy link
Contributor

You probably want #19 merged before this one, right?

@IRCody
Copy link
Contributor Author

IRCody commented Sep 14, 2016

I guess since it seems like #19 changes the path to the binary in s3, which would require a change in this anyways.

lynxbat
lynxbat approved these changes Sep 15, 2016
View reviewed changes
Copy link

@lynxbat lynxbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such awesome

@IRCody
Adds large tests
e5bdd06 
Adds large tests and example that runs in docker-compose/kubernetes.

Adds README for examples/tasks and scripts.
@IRCody
Copy link
Contributor Author

IRCody commented Sep 15, 2016

I updated with the path change from #19.

@thomastaylor312
Copy link
Contributor

This tests run correctly in Jenkins as well. So this runs properly in that environment

thomastaylor312
thomastaylor312 approved these changes Sep 15, 2016
View reviewed changes
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run properly in Jenkins and the code looks good. This should be good to go

@IRCody IRCody merged commit 04e5743 into intelsdi-x:master Sep 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

@lynxbat lynxbat lynxbat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IRCody @kindermoumoute @thomastaylor312 @lynxbat