Adding simple handling of Swagger 2.0 security schemes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hehe Ok, I see that the annotations are here 😄 |
…h with empty path
|
Sorry about the last two commits... I think they're good, but wasn't meaning to pull them. I just neglected to make a branch for this pull. |
ibaca
reviewed
Jul 18, 2018
|
|
||
| public FailedStatusCodeException(int status, String msg) { | ||
| public FailedStatusCodeException(int status, String responseText, String msg) { |
There was a problem hiding this comment.
about adding more info into the exception, the currently recommended strategy is to add a RequestResourceBuilder.unexpectedMapper and extend the FailedStatusCodeException to add more data. We internally just extract whatever info we need from the request, and expose it in the exception message, so we don't need to extend the base exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created annotations and tracking code to allow for a set of security tokens to be automatically handled.
There are 2 main drawbacks at this point: