-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with iOS 8 #42
Conversation
👍 |
Awesome, thanks so much! Should have the time to peek over this tomorrow. |
👍 |
Looks great, thanks so much! I'm a bit concerned by the failing CI build, but the tests appear to be passing for me locally; I'm going to merge this, hope that it's a flaky test, and investigate later if need be. |
Yeah, for me too, the tests passed locally so I did not touched anything since there is something written about fails on iPad. |
Hm. It appears to be failing locally when the tests are run via Tracking here. Not sure I'll have the time to fix this today, but I'm going to want to get that working before releasing a new version on CocoaPods. |
And thank YOU for contributing! 😄 |
@lazerwalker can you tag a new release plz? |
@shouze Just tagged and pushed This release doesn't actually fix the CI issue (the test has been pended out for CI — see #44), and also lacks @3x assets for the 6+ (#43), but you're right in that getting a build out that actually works on iOS 8 is pretty important. |
@lazerwalker thx! |
No description provided.