Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with iOS 8 #42

Merged
merged 2 commits into from
Oct 10, 2014
Merged

Fix issues with iOS 8 #42

merged 2 commits into from
Oct 10, 2014

Conversation

ipodishima
Copy link
Contributor

No description provided.

@shouze
Copy link

shouze commented Oct 7, 2014

👍

@lazerwalker
Copy link
Member

Awesome, thanks so much! Should have the time to peek over this tomorrow.

@Ekhoo
Copy link

Ekhoo commented Oct 10, 2014

👍

@lazerwalker
Copy link
Member

Looks great, thanks so much!

I'm a bit concerned by the failing CI build, but the tests appear to be passing for me locally; I'm going to merge this, hope that it's a flaky test, and investigate later if need be.

lazerwalker added a commit that referenced this pull request Oct 10, 2014
@lazerwalker lazerwalker merged commit 32acefd into intentkit:master Oct 10, 2014
@ipodishima
Copy link
Contributor Author

Yeah, for me too, the tests passed locally so I did not touched anything since there is something written about fails on iPad.
Thanks for the merge ;)

@lazerwalker
Copy link
Member

Hm. It appears to be failing locally when the tests are run via rake test on the command line (the way Travis is set up to run them).

Tracking here. Not sure I'll have the time to fix this today, but I'm going to want to get that working before releasing a new version on CocoaPods.

@lazerwalker
Copy link
Member

And thank YOU for contributing! 😄

@shouze
Copy link

shouze commented Oct 10, 2014

@lazerwalker can you tag a new release plz?

@lazerwalker
Copy link
Member

@shouze Just tagged and pushed 0.7.0, both here and to CocoaPods trunk.

This release doesn't actually fix the CI issue (the test has been pended out for CI — see #44), and also lacks @3x assets for the 6+ (#43), but you're right in that getting a build out that actually works on iOS 8 is pretty important.

@shouze
Copy link

shouze commented Oct 10, 2014

@lazerwalker thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants