Rollbar environment #258
Merged
Rollbar environment #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -1,6 +1,7 @@ | |||
| Rollbar.configure do |config| | |||
| config.enabled = ENV.has_key?('ROLLBAR_ACCESS_TOKEN') | |||
| config.access_token = ENV["ROLLBAR_ACCESS_TOKEN"] | |||
| config.environment = ENV['ROLLBAR_ENVIRONMENT'] | |||
There was a problem hiding this comment.
Would it make sense to add ROLLBAR_ENVIRONMENT to pliny/lib/template/.env.sample.erb?
ROLLBAR_ENVIRONMENT=development
There was a problem hiding this comment.
I intentionally left this out, as ROLLBAR_ACCESS_TOKEN isn't specified there. Which causes it to default to being disabled.
There was a problem hiding this comment.
Yeah, it makes sense. Thanks for explanation! 👍
I wasn't sure how Rollbar gem acts when environment is nil, but seems like it handles everything pretty well 😄
|
I know it's just cosmetics, but would it make sense to use |
|
@soulim Excellent point. I'll get it updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: #160.
@rwz what do you think?