Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package is not compatible with latest contentful 7.14.2 #26

Closed
cajoy opened this issue Apr 7, 2020 · 8 comments
Closed

Package is not compatible with latest contentful 7.14.2 #26

cajoy opened this issue Apr 7, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@cajoy
Copy link

cajoy commented Apr 7, 2020

I am getting errors after upgrade contentful to 7.14.2 :

TS2322: Type 'IRoute[]' is not assignable to type 'Entry<IRouteFields>[]'.
@cajoy
Copy link
Author

cajoy commented Apr 7, 2020

There is new field has been added. Which is missing in the model:

    space: {
      sys: SpaceLink
    }

@stevenpetryk
Copy link
Contributor

Ah, thanks for pointing out.

@stevenpetryk stevenpetryk added the bug Something isn't working label Apr 7, 2020
@cajoy
Copy link
Author

cajoy commented Apr 15, 2020

Is there any ETA?

@stevenpetryk
Copy link
Contributor

Today! 😄

@stevenpetryk
Copy link
Contributor

Upon fixing this, I realized that our build is broken by contentful/contentful.js#398. I'm going to hold off on making this change until that PR is merged so that we can set a good peerDependency constraint on contentful.

stevenpetryk pushed a commit that referenced this issue Apr 16, 2020
feat(codegen): support contentful v7.14.2 and above
1a81de3 
Contentful changed their typings for `space` in a minor version update, meaning that users of this
library had incorrect types.

BREAKING CHANGE: Drops compatibility with `contentful` versions lower than 7.14.2

Closes #26 but blocked by contentful/contentful.js#398
@stevenpetryk
Copy link
Contributor

In fact, space was never meant to be required, so this problem may fix itself. But let's wait on 398 and see.

@stevenpetryk stevenpetryk mentioned this issue Apr 16, 2020
Closed
stevenpetryk pushed a commit that referenced this issue Apr 16, 2020
feat(codegen): support contentful v7.14.2 and above
6d290be 
Contentful changed their typings for `space` in a minor version update, meaning that users of this library had incorrect types.

BREAKING CHANGE: Drops compatibility with `contentful` versions lower than 7.14.2

Closes #26 but blocked by contentful/contentful.js#398
@stevenpetryk
Copy link
Contributor

@cajoy you should be able to upgrade contentful to 7.14.3 to resolve this issue now. Closing this out and the PR.

@cajoy
Copy link
Author

cajoy commented Apr 29, 2020

I am on "contentful": "^7.14.4",

And the issue still exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codegen): support contentful v7.14.2 and above intercom/contentful-typescript-codegen
2 participants
@cajoy @stevenpetryk