refactor: better caching, optional auth check #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
commented
Jun 22, 2023
| @@ -262,7 +289,7 @@ pub async fn start_http( | |||
| allowance_config: AllowanceConfig, | |||
| ) -> jsonrpc_http_server::CloseHandle { | |||
| let mut io = IoHandler::default(); | |||
| let store = Store::new(Config::new("./kv")).expect("Unable to open kv store"); | |||
| let store = Store::new(Config::new("./kv").flush_every_ms(100)).expect("Unable to open kv store"); | |||
There was a problem hiding this comment.
I think the faucet previously did not write state to disk so the claim state did not persist restarts. Picked the value arbitrarily but we can probably increase it to something more sensible.
sander2
reviewed
Jun 23, 2023
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478
auth_urlsetManually tested to avoid spending too much time on this right now before launch setting up mocks, etc.. The tests are anyway very slow so I would like to spend time refactoring this code anyway. It would also be nice to do away with the encoded input parameter to simplify manual testing.