Merge currency specific bitcoin wallets #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
refactor/merge-wallets
branch
from
5120ee5
to
388d744
Compare
sander2
reviewed
Jul 20, 2023
There was a problem hiding this comment.
I'm a little bit worried about the fact that all vaults will now use the same rpc connection - specifically of concurrent access. I think that it'll be mostly ok, since we already were using the connection from multiple tasks, and we have the locking in place for tx creation. But please also have a think about it
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
refactor/merge-wallets
branch
from
ea2a45b
to
9406775
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
approved these changes
Jul 21, 2023
| tracing::info!("initial status: = {scanning_status:?}"); | ||
| let account_id = btc_parachain.get_account_id(); | ||
| let mut scanning_status = RescanStatus::get(&account_id, db)?; | ||
| tracing::info!("Scanning: {scanning_status:?}"); |
There was a problem hiding this comment.
Not quite accurate since scanning range is updated below based on issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484
Adds a new bitcoin wallet with the suffix "shared" and migrates all keys from the currency specific wallets. I went back and forth a bit on the metrics but I added a second commit which merges those that make sense. If we revert that commit the metrics are duplicated for each vault label.