fix: get_transaction does not work for non-wallet txs #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
reviewed
Aug 1, 2023
| Err(e) => Err(e.into()), | ||
| }?) | ||
| let (block_hash, fee) = retry(get_exponential_backoff(), || async { | ||
| if is_wallet { |
There was a problem hiding this comment.
Can we use https://github.com/interlay/interbtc-clients/blob/eeb2fda6d584dbf851ad851dc013e3cf52463de4/bitcoin/src/lib.rs#L750C27-L750C27 ? I'm not sure it works, it looks like it might need decoding, but would be nice to avoid having to branch here
There was a problem hiding this comment.
We would need to manually calculate the fee for the metrics which I'd like to avoid adding right now (to unblock the next release).
gregdhill
force-pushed
the
fix/get-tx
branch
2 times, most recently
from
d7bcd44
to
cef1c28
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
sander2
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases the
wait_for_transaction_metadatamethod would never return when monitoring issue txs (viaprocess_issue_requests) since most transactions are external to the wallet and the RPC call would fail silently. This was the cause of the failure in the API tests here but I assume this also affects production.As pointed out by @sander2, this bug was only recently introduced here: https://github.com/interlay/interbtc-clients/pull/505/files#diff-81edb9dff73f644e5f570d16889c0316836cb9730ef3bcdf1b3a2707e5336989R299-R301