fix: hardcode past slot duration or read from chain #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
previously approved these changes
Jul 12, 2023
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
gregdhill
force-pushed
the
fix/kintsugi-syncing
branch
from
e9f3287
to
5ab7a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #978
I think we made a mistake here since the blocks authored on kintsugi prior to height 1983993 would be calculated using a slot duration of 6s. I have tested this is now working from a fresh sync, but I still need to confirm whether the fix will hold after block 1983993 without restarting - I'm sure this value is only fetched on startup and I don't think there is any internal logic to update it.
EDIT: syncing works as expected after block 1983993 without restarting