-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] fix: prevent spv attack by checking coinbase proof #1112
Conversation
80b109c
to
13a9767
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are non-blocking but requesting changes specifically only for adding documentation and cleaning up the unused code. All other comments are mostly nitpicks, but in general the solution looks good.
I also verified that we can indeed use the first txid returned by esplora to get the coinbase transaction. Here's a quick one-liner to check that via curl -s https://blockstream.info/api/tx/$(curl -s https://blockstream.info/api/block/$(curl -s https://blockstream.info/api/block-height/799160)/txids | jq -r '.[0]') | jq '.vin' |
Closes #1073