feat: forward when amount is zero #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmoon
requested changes
Nov 29, 2017
src/handlers/public/send-transfer.js
Outdated
| if (nextHop.local) { | ||
| const finalAmount = new BigNumber(data.amount) | ||
| // Always forward when finalAmount is 0. | ||
| if (nextHop.local && !finalAmount.equals(0)) { |
There was a problem hiding this comment.
I think it's fine to just do data.amount !== '0'. Any advantage to using BigNumber here?
justmoon
approved these changes
Nov 29, 2017
|
I was going to say: Perhaps wait for interledgerjs/ilp-connector#397 before merging to give folks a chance to discuss. But I was too slow. ^^ No harm, we can always revert if necessary. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.