Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate transfer id on webhook retries #223

Closed
wilsonianb opened this issue Jan 28, 2022 · 0 comments · Fixed by #228
Closed

Duplicate transfer id on webhook retries #223

wilsonianb opened this issue Jan 28, 2022 · 0 comments · Fixed by #228
Assignees
@wilsonianb
Labels
pkg: backend Changes in the backend package. type: bug Something isn't working

Comments

@wilsonianb
Copy link
Contributor

wilsonianb commented Jan 28, 2022 •
edited
Loading

Invoices and outgoing payments use the same webhook id as withdrawal transfer ids across attempts, which will result in a TransferExists TB error on retries.
https://github.com/interledger/rafiki/blob/main/packages/backend/src/open_payments/invoice/service.ts#L207
Unique transfer ids should be used on each attempt (unless Tigerbeetle supported two-phase commit transfers without a timeout).

If we had a limit on webhook retries, then it might be fine to use a single transfer with a timeout corresponding to that limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilsonianb wilsonianb

Labels
pkg: backend Changes in the backend package. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backend): manage webhook event lifecycle in webhook service interledger/rafiki
1 participant
@wilsonianb