Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate webhook lifecycle management #225

Closed
wilsonianb opened this issue Feb 1, 2022 · 2 comments · Fixed by #228
Closed

Consolidate webhook lifecycle management #225

wilsonianb opened this issue Feb 1, 2022 · 2 comments · Fixed by #228
Assignees
Labels
pkg: backend Changes in the backend package.

Comments

@wilsonianb
Copy link
Contributor

wilsonianb commented Feb 1, 2022

The invoice and outgoing payment services currently each handle webhook retry attempts.
Instead of duplicating that further for #220 (and potentially asset and peer liquidity webhooks) manage webhook lifecycle in a single service.
This will also allow bugs like #223 to be fixed in one place.

@wilsonianb
Copy link
Contributor Author

Having the wallet call relevant apis upon receiving webhook events (instead of using webhook response codes to communicate to Rafiki that the wallet has performed certain internal actions) means the webhook service wouldn't need to notify relevant services about successful webhook requests.

@wilsonianb
Copy link
Contributor Author

By persisting webhook events, the admin api could have deposit and withdrawal liquidity mutation resolvers that take the webhook id instead of having different resolvers for different account types that take arbitrary amounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant