Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update mutations to use input object type, add idempotencyKey #1398

Merged
merged 41 commits into from
May 9, 2023
Merged

feat: update mutations to use input object type, add idempotencyKey #1398

merged 41 commits into from
May 9, 2023

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented May 1, 2023 •
edited
Loading

Changes proposed in this pull request

  • Add optional idempotencyKey to non-liquidity mutations
  • Convert mutations to all use input objects (some of them were just using single primitive parameters, like deletePeer revokePaymentPointerKey triggerPaymentPointerEvents)

Context

  • Related Postman PR

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

mkurapov added 30 commits April 13, 2023 13:01
@mkurapov
feat: graphql cache middleware
e7aebb6
@mkurapov
feat: update cache to contain intermediate state
e475bb9
@mkurapov
refactor: remove PENDING state
2f535c1
@mkurapov
fix: update CacheDataStore interface
ec9cb3f
@mkurapov
feat: add fieldName to gql middleware
a2e4f39
@mkurapov
fix: update dependencies
d6b65d7
@mkurapov
feat: use middleware
0f8d8d9
@mkurapov
feat: bump ttl to 1 day
97dbaf9
@mkurapov
chore: simplify middleware types
e322617
@mkurapov
fix: simplify middleware and data-store types
ed9a47a
@mkurapov
fix: add catch block if failed to set cache originally
136a57f
@mkurapov
test: add tests for cache middleware
f5ce646
@mkurapov
chore: update graphql middleware log
bcc9bbd
@mkurapov
feat: add idempotencyKey arg to createAsset mutation
048082a
@mkurapov
test: add test for graphql middleware
0726f93
@mkurapov
Merge branch 'main' into 382/mk/idempotency
db43bc3 
# Conflicts:
#	packages/backend/package.json
#	pnpm-lock.yaml
@mkurapov
test: fix resolver asset graphql tests
3514fe9
@mkurapov
feat: make idempotencyKey optional in createAsset mutation
263b12e
@mkurapov
Revert "test: fix resolver asset graphql tests"
a02a5a2 
This reverts commit 3514fe9.
@mkurapov
test: add tests for redis cache
88cc573
@mkurapov
Merge branch 'main' into 382/mk/idempotency
d0f58a7
@mkurapov
chore: rearrange tests
d95e320
@mkurapov
Merge branch 'main' into 382/mk/idempotency
9060852
@mkurapov
docs: add idempotencyKey description
f5dca41
@mkurapov
docs: add idempotencyKey description
252c8c5
@mkurapov
Merge branch '382/mk/idempotency' of github.com:interledger/rafiki in…
f92ac59 
…to 382/mk/idempotency
@mkurapov
Merge branch 'main' into 382/mk/idempotency
b3906c2
@mkurapov
feat: add required idempotencyKey to liquidity GQL resolvers
8ee68fb
@mkurapov
feat: add auto-generated files
e67a7c9
@mkurapov
chore: revert later change
0c901a8
@github-actions github-actions bot added pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-ase type: source Changes business logic type: tests Testing related labels May 1, 2023
mkurapov
mkurapov commented May 1, 2023
View reviewed changes
packages/backend/src/graphql/schema.graphql
@@ -231,13 +235,6 @@ input HttpOutgoingInput {
endpoint: String!
}

input AssetInput {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't used

@mkurapov mkurapov marked this pull request as ready for review May 1, 2023 21:26
@mkurapov mkurapov mentioned this pull request May 1, 2023
Merged
4 tasks
@mkurapov mkurapov requested a review from sabineschaller May 1, 2023 22:32
sabineschaller
sabineschaller approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@sabineschaller sabineschaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 382/mk/adding-key to main May 9, 2023 08:38
@mkurapov
Merge branch 'main' into 382/mk/add-optional-key
e4beddf 
# Conflicts:
#	localenv/mock-account-servicing-entity/generated/graphql.ts
#	packages/backend/src/graphql/generated/graphql.ts
#	packages/frontend/app/generated/graphql.ts
@mkurapov mkurapov merged commit 5fa3662 into main May 9, 2023
@mkurapov mkurapov deleted the 382/mk/add-optional-key branch May 9, 2023 08:52
@BlairCurrey BlairCurrey mentioned this pull request May 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabineschaller sabineschaller sabineschaller approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurapov @sabineschaller