feat: only poll for payment pointers in the open payments middleware #1528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The function
paymentPointerService.getByUrl
was used in the remoteIncomingPayment service, when getting or creating a local or remote incoming payment, in order to determine whether the payment pointer URL provided was or wasn't a local payment pointer. This means, whenever we call "get receiver" or "create receiver", we end up having to wait for the function to poll for the payment pointer at the ASE. This adds a lot of extra overhead for cases where often, the receiver in question is at at another, remote Rafiki instance. I believe we should only end up polling for the payment pointer during open payments calls: meaning, only in the payment pointer middleware.Context
Checklist
fixes #number