Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only poll for payment pointers in the open payments middleware #1528

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

mkurapov
Copy link
Contributor

@mkurapov mkurapov commented Jun 28, 2023

Changes proposed in this pull request

The function paymentPointerService.getByUrl was used in the remoteIncomingPayment service, when getting or creating a local or remote incoming payment, in order to determine whether the payment pointer URL provided was or wasn't a local payment pointer. This means, whenever we call "get receiver" or "create receiver", we end up having to wait for the function to poll for the payment pointer at the ASE. This adds a lot of extra overhead for cases where often, the receiver in question is at at another, remote Rafiki instance. I believe we should only end up polling for the payment pointer during open payments calls: meaning, only in the payment pointer middleware.

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit bfa02f8
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/649c4ab2a94524000992809d

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related labels Jun 28, 2023
@mkurapov mkurapov marked this pull request as ready for review June 29, 2023 14:06
@mkurapov mkurapov requested a review from BlairCurrey June 29, 2023 14:19
@mkurapov mkurapov linked an issue Jun 29, 2023 that may be closed by this pull request
@mkurapov mkurapov merged commit 01be0ec into main Jun 29, 2023
@mkurapov mkurapov deleted the mk/1419/update-pp-lookup branch June 29, 2023 18:41
Muasa-harman pushed a commit to Muasa-harman/rafiki that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interact with ASE on Payment Pointer request
2 participants