-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: liquidity webhooks #1782
feat: liquidity webhooks #1782
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
packages/documentation/src/content/docs/integration/event-handlers.md
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/getting-started.md
Outdated
Show resolved
Hide resolved
packages/documentation/src/content/docs/integration/event-handlers.md
Outdated
Show resolved
Hide resolved
There are still mentions of
The schema dump also doesn't contain the liquidity threshold field when explaining Assets or Peers. |
@huijing could you help with that? Are these files generated or did you write them? They contain a lot of html. |
@@ -8,6 +8,7 @@ exports.up = function (knex) { | |||
table.smallint('scale').unsigned().notNullable() | |||
|
|||
table.bigInteger('withdrawalThreshold').nullable() | |||
table.bigInteger('liquidityThreshold').nullable() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these fields as a new migration? Something that we started doing here since it's friendler to existing deployments (e.g. testnet): #1522 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I wasn't aware of the discussion and not thinking this through.
That was generated by the graphql-markdown plugin. Can you tell me what the expected output should be? Basically, I generate the raw-schema dump then move the output into the schema.mdx file. As for the mutation.md, that is a legacy file copied over from before the Astro migration. |
I changed the endpoint to be |
@huijing I ran the docs generation command but only 1 file was updated:
The following 2 were not updated:
|
Changes proposed in this pull request
Context
Checklist
fixes #number