Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2479): add client to outgoing/incoming payments / webhooks and outgoing tests. #2487

Merged
merged 25 commits into from
Apr 17, 2024
Merged

feat(2479): add client to outgoing/incoming payments / webhooks and outgoing tests. #2487

merged 25 commits into from
Apr 17, 2024

Conversation

koekiebox
Copy link
Collaborator

@koekiebox koekiebox commented Mar 5, 2024 •
edited
Loading

Changes proposed in this pull request

Please see logged issue:
#2479

Context

#2479

Checklist

  • Related issues linked using fixes #2479
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@koekiebox koekiebox self-assigned this Mar 5, 2024
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Mar 5, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit bd3bbf8
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/661f89bed9b9f40008290a5d

@github-actions github-actions bot added pkg: frontend Changes in the frontend package. pkg: mock-ase pkg: documentation Changes in the documentation package. labels Mar 7, 2024
@koekiebox koekiebox marked this pull request as draft March 7, 2024 10:53
@koekiebox koekiebox requested a review from sabineschaller March 7, 2024 13:01
@github-actions github-actions bot removed the pkg: documentation Changes in the documentation package. label Mar 7, 2024
@github-actions github-actions bot added the type: documentation (archived) Improvements or additions to documentation label Apr 8, 2024
@koekiebox koekiebox marked this pull request as ready for review April 8, 2024 08:05
njlie
njlie previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the type: localenv Local playground label Apr 16, 2024
@sabineschaller
Copy link
Member

Can we rename the PR title to also include incoming payments or to just talk about payments?

@koekiebox koekiebox changed the title feat(2479): add client to outgoing payment and outgoing tests. feat(2479): add client to outgoing/incoming payments / webhooks and outgoing tests. Apr 16, 2024
BlairCurrey
BlairCurrey previously approved these changes Apr 16, 2024
View reviewed changes
@koekiebox koekiebox requested a review from BlairCurrey April 17, 2024 08:34
@koekiebox koekiebox merged commit 8d728f8 into main Apr 17, 2024
30 checks passed
@koekiebox koekiebox deleted the issues/2479-surface-client branch April 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey BlairCurrey approved these changes

@mkurapov mkurapov Awaiting requested review from mkurapov

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

@njlie njlie Awaiting requested review from njlie

Assignees

@koekiebox koekiebox

Labels
pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: documentation (archived) Improvements or additions to documentation type: localenv Local playground type: source Changes business logic type: tests Testing related
Projects
Rafiki
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koekiebox @sabineschaller @BlairCurrey @mkurapov @njlie