chore: Revert "feat(backend): support single phase transfer in connector" #2630
Conversation
)" This reverts commit 81f8a05.
github-actions
bot
added
type: tests
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
sabineschaller
changed the title
mkurapov
changed the title
mkurapov
changed the title
| expect(incomingPayment.receivedAmount).toMatchObject({ | ||
| assetCode: 'EUR', | ||
| assetScale: 2, | ||
| value: 501n |
There was a problem hiding this comment.
I understand that the receivedAmount may be greater than the sentAmount during cross currency transactions (i.e. you need at least 0.02 USD to reach a minimum of 0.01 EUR, if USD < EUR).
However, this receivedAmount feels wrong to me:
original receiveAmount = 500
sentAmount = 550
receivedAmount = 501
with an exchange rate of 0.91 as tested above, we have 550 * 0.91 = 500.5, which is under the final receivedAmount of 501. This signifies somewhere in ILP pay there is a Math.ceil that ends up making money out of nothing. Are my assumptions correct in the fact that this seems like a problem?
There was a problem hiding this comment.
I was about to say that this could be because the stream was closed too late but given that the packet size is huge, that can't be it. I guess we have a rounding problem somewhere.
There was a problem hiding this comment.
Unfourtunately will need to dive in deeper into ILP pay, since this is just the default behaviour. Will merge in for now, since it is the status quo at this point anyway.
| expect(incomingPayment.receivedAmount).toMatchObject({ | ||
| assetCode: 'EUR', | ||
| assetScale: 2, | ||
| value: 501n |
There was a problem hiding this comment.
I was about to say that this could be because the stream was closed too late but given that the packet size is huge, that can't be it. I guess we have a rounding problem somewhere.
This reverts commit 81f8a05.
Changes proposed in this pull request
Context
Progress towards fixing #2629
Checklist
fixes #number