feat(auth): tenants table v1 #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: source
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
njlie
requested review from
koekiebox,
BlairCurrey,
mkurapov,
golobitch,
sanducb and
oana-lolea
golobitch
reviewed
Nov 26, 2024
golobitch
approved these changes
Nov 27, 2024
sanducb
approved these changes
Nov 28, 2024
mkurapov
approved these changes
Nov 28, 2024
mkurapov
requested changes
Nov 28, 2024
Comment on lines
+11
to
+12
| table.timestamp('createdAt').defaultTo(knex.fn.now()) | ||
| table.timestamp('updatedAt').defaultTo(knex.fn.now()) |
There was a problem hiding this comment.
Are these generated in this table, or passed over from backend?
Should we also include deletedAt?
There was a problem hiding this comment.
I would say that yes, this createdAt and updatedAt needs to be generated in this table since it is different entity. Bot somehow, still connected with the one in backend. with createdAt we get info when was the entity created in that database, not when it was created in the backed database. What do you think ?
There was a problem hiding this comment.
Generating the timestamps in this table should be fine, that's consistent with what we have everywhere else.
But we should include deletedAt column, which should just be passed in from the deleteTenant GraphQL API call.
njlie
force-pushed
the
nl/3113/auth-tenants-table
branch
from
dc10e8f to
b9c2a72
Compare
mkurapov
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
Closes #3113.
Checklist
fixes #numberuser-docslabel (if necessary)