Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): tenant service #3144

Merged
merged 7 commits into from
Dec 3, 2024
Merged

feat(auth): tenant service #3144

merged 7 commits into from
Dec 3, 2024

Conversation

BlairCurrey
Copy link
Contributor

@BlairCurrey BlairCurrey commented Dec 2, 2024 •
edited
Loading

Changes proposed in this pull request

  • Adds tenant service to auth

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Dec 2, 2024
@njlie njlie linked an issue Dec 2, 2024 that may be closed by this pull request
[Multi-Tenant] auth tenant service #3122
Closed
5 tasks
mkurapov
mkurapov reviewed Dec 2, 2024
View reviewed changes
packages/auth/src/tenant/service.ts Outdated
deps: ServiceDependencies,
id: string
): Promise<boolean> {
const deleted = await Tenant.query(deps.knex).deleteById(id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do a soft delete here, we can already leverage the deletedAt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to soft delete

@BlairCurrey BlairCurrey merged commit 349b01e into 2893/multi-tenancy-v1 Dec 3, 2024
24 of 36 checks passed
@BlairCurrey BlairCurrey deleted the bc/3122/auth-tenant-service branch December 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanducb sanducb sanducb approved these changes

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie Awaiting requested review from njlie

@golobitch golobitch Awaiting requested review from golobitch

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-Tenant] auth tenant service
3 participants
@BlairCurrey @mkurapov @sanducb