Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): access token rotation #375

Merged
merged 12 commits into from
Jul 26, 2022
Merged

feat(auth): access token rotation #375

merged 12 commits into from
Jul 26, 2022

Conversation

dclipp
Copy link
Contributor

@dclipp dclipp commented Jun 23, 2022 •
edited
Loading

Changes proposed in this pull request

  • Implements access token rotation

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@dclipp dclipp requested review from sabineschaller and njlie June 23, 2022 01:10
@dclipp dclipp self-assigned this Jun 23, 2022
@github-actions github-actions bot added pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related labels Jun 23, 2022
njlie
njlie reviewed Jul 1, 2022
View reviewed changes
packages/auth/src/app.ts Outdated Show resolved Hide resolved
@dclipp dclipp force-pushed the dc-token-rotation branch from 422f084 to 02e88dc Compare July 1, 2022 21:49
@dclipp dclipp requested review from sabineschaller and njlie July 1, 2022 23:49
sabineschaller
sabineschaller reviewed Jul 6, 2022
View reviewed changes
Copy link
Member

@sabineschaller sabineschaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update your PR description to not mention the revoked column anymore.

packages/auth/src/accessToken/routes.ts Outdated Show resolved Hide resolved
packages/auth/src/accessToken/service.ts Outdated Show resolved Hide resolved
packages/auth/src/accessToken/routes.test.ts Outdated Show resolved Hide resolved
@dclipp dclipp requested a review from sabineschaller July 7, 2022 22:57
sabineschaller
sabineschaller reviewed Jul 12, 2022
View reviewed changes
packages/auth/src/accessToken/service.ts Outdated Show resolved Hide resolved
packages/auth/src/accessToken/service.ts Outdated Show resolved Hide resolved
packages/auth/src/accessToken/service.ts Outdated Show resolved Hide resolved
packages/auth/src/accessToken/routes.ts Outdated Show resolved Hide resolved
njlie
njlie previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@njlie njlie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs merge conflicts resolved

@dclipp dclipp requested review from sabineschaller and njlie July 22, 2022 23:11
@dclipp dclipp merged commit 0da6162 into main Jul 26, 2022
@dclipp dclipp deleted the dc-token-rotation branch July 26, 2022 23:58
@dclipp dclipp mentioned this pull request Aug 11, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlie njlie njlie approved these changes

@sabineschaller sabineschaller Awaiting requested review from sabineschaller

Assignees

@dclipp dclipp

Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rotate access token
3 participants
@dclipp @sabineschaller @njlie