Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-4: Change RejectionMessage to match ILP (RFC-3) #332

Closed
justmoon opened this issue Nov 7, 2017 · 5 comments · Fixed by #347
Closed

RFC-4: Change RejectionMessage to match ILP (RFC-3) #332

justmoon opened this issue Nov 7, 2017 · 5 comments · Fixed by #347

Comments

@justmoon
Copy link
Member

justmoon commented Nov 7, 2017

There are a couple of issues with the RFC-4 RejectionMessage:

  • forwarded_by should be an array
  • message does not exist in the ILP packet and should presumably move to additional_info
@justmoon justmoon mentioned this issue Nov 7, 2017
Closed
@michielbdejong
Copy link
Contributor

This would break all existing plugins, right? What problems are caused by it currently not being an array?

@justmoon
Copy link
Member Author

No, the plugins are currently broken, this would fix them. Forwarded by is an array in ILP, this is just a bug in the LPI that propagated to the plugins.

@michielbdejong
Copy link
Contributor

Interesting! Reminds me of https://en.wikipedia.org/wiki/HTTP_referer#Etymology.

@sappenin sappenin mentioned this issue Nov 14, 2017
Closed
@justmoon justmoon mentioned this issue Dec 2, 2017
Merged
This was referenced Dec 5, 2017
Closed
Closed
@emschwartz
Copy link
Member

Given #347, I think we can leave LPIv1 as it is and make sure to include these changes in v2

This was referenced Dec 5, 2017
Closed
Merged
emschwartz referenced this issue in interledger-deprecated/ilp-plugin-payment-channel-framework Dec 5, 2017
@emschwartz
fix: rejectionReason.forwarded_by should be a string
127ee11 
related to https://github.com/interledger/rfcs/issues/332\#issuecomment-349411944
@emschwartz emschwartz mentioned this issue Dec 5, 2017
Merged
emschwartz referenced this issue in interledger-deprecated/ilp-plugin-payment-channel-framework Dec 5, 2017
@emschwartz
fix: rejectionReason.forwarded_by should be a string
d437f72 
related to https://github.com/interledger/rfcs/issues/332\#issuecomment-349411944
@emschwartz
Copy link
Member

@justmoon can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ledger Plugin Interface v2 interledger/rfcs
3 participants
@justmoon @michielbdejong @emschwartz