Forwarded by should be an array #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justmoon
force-pushed
the
feat/st-forwarded-by-array
branch
from
a307c2f
to
7875c91
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 83.54% 83.51% -0.03%
==========================================
Files 34 34
Lines 1209 1213 +4
Branches 199 201 +2
==========================================
+ Hits 1010 1013 +3
- Misses 199 200 +1
Continue to review full report at Codecov.
|
michielbdejong
requested changes
Nov 14, 2017
There was a problem hiding this comment.
According to https://github.com/interledger/rfcs/blob/master/0004-ledger-plugin-interface/0004-ledger-plugin-interface.md#class-rejectionmessage forwarded_by should be "[t]he address of the last connector to forward the rejection"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests currently fail, because of interledger/rfcs#332, see RejectionMessage.json