Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Background] Handle token rotation synchronously #288

Closed
dianafulga opened this issue May 23, 2024 · 1 comment · Fixed by #305
Closed

[Background] Handle token rotation synchronously #288

dianafulga opened this issue May 23, 2024 · 1 comment · Fixed by #305
Assignees
@raducristianpopa
Labels
area: background Improvements or additions to extension background script
Milestone
WM extension alpha 2

Comments

@dianafulga
Copy link
Contributor

dianafulga commented May 23, 2024 •
edited by raducristianpopa
Loading

When there are multiple link tags on a page, each link tag may going to try to rotate its token

If there are multiple payment sessions for a tab and the token expires, each payment session will try to rotate the token and the monetization flow will break because of the race condition.

To be implemented:

  • move token rotation logic in OpenPaymentsService
  • dedupe token rotation calls and cache the results for a small amount of time
@dianafulga dianafulga added area: background Improvements or additions to extension background script beta labels May 23, 2024
@raducristianpopa raducristianpopa self-assigned this May 31, 2024
@tselit
Copy link

tselit commented Jun 4, 2024 •
edited
Loading

Investigating approaches and revising this in progress.
Aiming to get into review by end of week.

@raducristianpopa raducristianpopa changed the title [Background] [TO REFINE] - handle token rotation synchronously [Background] Handle token rotation synchronously Jun 5, 2024
@raducristianpopa raducristianpopa mentioned this issue Jun 5, 2024
Merged
@tselit tselit removed beta labels Jun 20, 2024
@tselit tselit modified the milestone: WM extension alpha 0.1.1 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raducristianpopa raducristianpopa

Labels
area: background Improvements or additions to extension background script
Projects
Web Monetization Extension
Archived in project
Milestone
WM extension alpha 2
Development

Successfully merging a pull request may close this issue.

fix: deduplicate token rotation requests interledger/web-monetization-extension
3 participants
@dianafulga @raducristianpopa @tselit