Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deduplicate token rotation requests #305

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

raducristianpopa
Copy link
Member

Context

Closes #288.

Changes proposed in this pull request

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jun 5, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Jun 5, 2024

Extension builds preview

Name Link
Latest commit 4b237b0
Latest job logs Run #9413540697
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title chore: deduplicate token rotation requests fix: deduplicate token rotation requests Jun 5, 2024
dianafulga
dianafulga previously approved these changes Jun 6, 2024
@raducristianpopa raducristianpopa marked this pull request as ready for review June 6, 2024 09:38
sidvishnoi
sidvishnoi previously approved these changes Jun 6, 2024
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Looks good.

src/background/services/deduplicator.ts Outdated Show resolved Hide resolved
src/background/services/openPayments.ts Outdated Show resolved Hide resolved
src/background/services/paymentSession.ts Show resolved Hide resolved
src/background/services/paymentSession.ts Outdated Show resolved Hide resolved
src/background/services/paymentSession.ts Show resolved Hide resolved
@github-actions github-actions bot added the area: popup Improvements or additions to extension popup label Jun 7, 2024
@raducristianpopa raducristianpopa merged commit 8e97588 into main Jun 7, 2024
7 checks passed
@raducristianpopa raducristianpopa deleted the rp/288/token-rotation branch June 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Background] Handle token rotation synchronously
3 participants