-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support manifest v3 #313
Conversation
Extension builds preview
|
I would keep them for now. We can probably default to using MV3 (renaming
i don't think so, since the button will be disabled and we check the permission when the user submits the form. |
So, content script also won't be injected if current URL isn't doesn't have the permission. We ask for the permission only on connect screen, but if some has connected before, and they update the extension, they won't see that they haven't given the permissions. |
that was a leftover from previous attempt (adding a route for missing permission)
Context
Closes #23
Changes proposed in this pull request
Changes proposed in this pull request
manifestv3.json
, and modify it as needed for Firefox/Chrome support.hosts
permissions on install (automatically or manually), show an error message that permissions are required, along with a button to request permission. No other part of UI is shown until we've the permissions.document.createElement('script')
, anddocument
isn't defined in MV3 background service workers, which causes a fatal crash.Questions:
Decided to retain functionality, with a--mv2
flag during build.