Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add global payment switch #773

Merged
merged 16 commits into from
Dec 17, 2024
Merged

feat: add global payment switch #773

merged 16 commits into from
Dec 17, 2024

Conversation

sidvishnoi
Copy link
Member

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup area: i18n area: pages Changes to any of extension's pages area: shared Changes to shared libraries and utilities labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 1b90324
Latest job logs Run #12369579052
BadgeDownload
BadgeDownload

@sidvishnoi
Copy link
Member Author

The toggle doesn't look right here, and it's not clear what the toggle would do. Will add power icon.

@sidvishnoi sidvishnoi mentioned this pull request Dec 12, 2024
Closed
@sidvishnoi
Copy link
Member Author

Screencast.from.2024-12-13.15-39-14.mp4

@sidvishnoi sidvishnoi marked this pull request as ready for review December 13, 2024 10:11
raducristianpopa
raducristianpopa reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a safety measure, we can check if payments are enabled in the MonetizationService.pay as well.

src/background/services/monetization.ts Outdated Show resolved Hide resolved
src/pages/popup/components/TogglePaymentsButton.tsx Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi commented Dec 16, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi
show only only home screen, along with settings icon
5c33838 
If we show on settings screen, the button on-click disappears with no
visual change, which is confusing (change is shown only on home screen).
So, show the toggle button only when the "settings" icon is shown.
@sidvishnoi sidvishnoi requested a review from DarianM December 17, 2024 07:34
@sidvishnoi sidvishnoi merged commit 824112c into main Dec 17, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the global-payment-toggle branch December 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

@DarianM DarianM DarianM approved these changes

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: i18n area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: shared Changes to shared libraries and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to disable WM Cannot enable continuous payments on non-monetized screen
3 participants
@sidvishnoi @DarianM @raducristianpopa