Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(background): remove OP error map as unused #785

Merged
merged 1 commit into from
Dec 17, 2024
Merged

refactor(background): remove OP error map as unused #785

merged 1 commit into from
Dec 17, 2024

Conversation

sidvishnoi
Copy link
Member

No description provided.

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Extension builds preview

Name Link
Latest commit e973e49
Latest job logs Run #12370442737
BadgeDownload
BadgeDownload

DarianM
DarianM approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we catch invalid client throughout different bindMessage cases now and we use error.code === 'invalid_client' instead of e.description for invalid client, so this cleanup LGTM

@sidvishnoi sidvishnoi changed the title refactor(background): remove OP error map (unused) refactor(background): remove OP error map as unused Dec 17, 2024
@sidvishnoi sidvishnoi merged commit a8926e6 into main Dec 17, 2024
10 checks passed
@sidvishnoi sidvishnoi deleted the remove-op-error-map branch December 17, 2024 10:04
sidvishnoi added a commit that referenced this pull request Dec 17, 2024
@sidvishnoi
refactor(background): remove OP error map as unused (#785)
8bf9f02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM DarianM approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @DarianM