Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popup): update global payment toggle UI #792

Merged
merged 4 commits into from
Dec 18, 2024
Merged

fix(Popup): update global payment toggle UI #792

merged 4 commits into from
Dec 18, 2024

Conversation

DarianM
Copy link
Member

@DarianM DarianM commented Dec 18, 2024 •
edited
Loading

Context

Closes #787 .

Changes proposed in this pull request

  • Removed the large power button on Home screen when disabled, display disable message only.
  • Always showing the toggle button in Header.
  • Show the default colored icon in toolbar, instead of disabled gray one.

@DarianM DarianM linked an issue Dec 18, 2024 that may be closed by this pull request
[UX feedback]: global payment toggle #787
Closed
@github-actions github-actions bot added area: popup Improvements or additions to extension popup area: pages Changes to any of extension's pages labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit ac2feb8
Latest job logs Run #12394580572
BadgeDownload
BadgeDownload

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Dec 18, 2024
@DarianM DarianM marked this pull request as ready for review December 18, 2024 11:51
@sidvishnoi sidvishnoi changed the title chore(ux): update global payment toggle UI fix(Popup): update global payment toggle UI Dec 18, 2024
sidvishnoi
sidvishnoi approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe the toggle's input should've onClick={(ev) => ev.currentTarget.blur()} so the focus styles get removed?

@sidvishnoi sidvishnoi merged commit c0b2055 into main Dec 18, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the 787-ux-feedback-global-payment-toggle branch December 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX feedback]: global payment toggle
2 participants
@DarianM @sidvishnoi