Rewrite Mode2Up to use CSS transforms + Lit #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
2 times, most recently
from
a2a3ddf to
cbffd2c
Compare
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
2 times, most recently
from
477d8f0 to
0bed79e
Compare
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
0bed79e to
d97dbf7
Compare
cdrini
changed the title
cdrini
changed the title
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
3ffb4fb to
dc52b88
Compare
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
==========================================
- Coverage 69.95% 68.35% -1.61%
==========================================
Files 59 61 +2
Lines 5342 5103 -239
Branches 1045 1062 +17
==========================================
- Hits 3737 3488 -249
- Misses 1586 1588 +2
- Partials 19 27 +8
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
9a93e66 to
27d677a
Compare
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
2 times, most recently
from
a875a0a to
7747089
Compare
BC: Remove no longer used: - BookReader.prototype.lastDisplayableIndex2up - BookReader.prototype.firstDisplayableIndex - BookReader.prototype.lastDisplayableIndex
Consistent with the way it was before, and a better UX.
Breaking Changes: - Remove BookReader#scrollDown - Remove BookReader#scrollUp - Remove BookReader#_scrollAmount All unused
Breaking changes: - Rm BookReader#stopFlipAnimations
Also some misc Mode2UpLit cleanups
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
7747089 to
3dc0265
Compare
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
a6c830a to
1c4be78
Compare
cdrini
force-pushed
the
refactor/mode-2up-lit
branch
from
574b8b6 to
1b5f370
Compare
|
QA'd by IA folks, CR'd by Isa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1145 . Closed #301 . Closes #881 .
QA. Tested on:
Complete black screen, not just BR. Also prod.Now works...