-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic cantaloupe sidecar. #8
base: main
Are you sure you want to change the base?
Conversation
Copying over a couple of comments from Slack just so they are here as well: Since this is now a sidecar, I'm assuming the ENV variable that gets set is using an IP? I've checked out the behavior of the code locally using Spinning up a local development copy using the PR branch, but using the DNS name It would be good to come up with a way that the container can also be run locally. One immediate idea that springs to mind is adding another line to the |
One other thing I've noticed - there are various headers that need to be set in order for Cantaloupe to produce the correct
With
|
…he new repo. Also some notes in readme.
…id nomad task starting order of operations.
Leaving this open but in the 14th Sept catch up we discussed closing this after merging the post-meeting-fixes branch as this should have all of the changes in. If we check once this is merged we will see if there is anything we missed. |
I've checked through this and I'm pretty confident that everything we needed from here is now in There are a couple of things we might want to pull out:
@robertkeizer any pointers for the last two? |
This relates to the following PRs:
Effectively this sets up the
cantaloupe
system as a sidecar to theiiif
python flask app.