Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remove Redundant 'Feedback' Button from the UI" #10197

Closed
SharkyBytes opened this issue Dec 24, 2024 · 1 comment · Fixed by #10198
Closed

"Remove Redundant 'Feedback' Button from the UI" #10197

SharkyBytes opened this issue Dec 24, 2024 · 1 comment · Fixed by #10198
Assignees
@SharkyBytes
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Response Issues which require feedback from lead Type: Bug Something isn't working. [managed]

Comments

@SharkyBytes
Copy link
Contributor

SharkyBytes commented Dec 24, 2024 •
edited
Loading

Problem

The "Feedback" button in the UI appears to be redundant now and may no longer serve a functional purpose. Removing it can streamline the interface and enhance the user experience.

image

Reproducing the bug

  1. Go to any Book details and then go to the overview tab of the book
  2. Do ...

  • Expected behavior:
    image

  • Actual behavior:
    image

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@SharkyBytes SharkyBytes added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Dec 24, 2024
@SharkyBytes
Copy link
Contributor Author

Hi @RayBB!

As per your suggestion, I’ve gone ahead and created this issue for the "Feedback" button removal. I’ll also be raising a PR shortly to address this. I’d appreciate your feedback or approval when you have the time to review it next week!

SharkyBytes added a commit to SharkyBytes/openlibrary that referenced this issue Dec 24, 2024
@SharkyBytes
Fix: Remove redundant 'Feedback' button from review_component.html (i…
525d2ff 
…nternetarchive#10197)
@SharkyBytes SharkyBytes mentioned this issue Dec 24, 2024
Merged
@RayBB RayBB added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Dec 24, 2024
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 25, 2024
mekarpeles pushed a commit that referenced this issue Dec 25, 2024
@SharkyBytes @pre-commit-ci
Fixed#10197: Removed redundant 'Feedback' button (#10198)
4bc59c8 
* Fix: Remove redundant 'Feedback' button from review_component.html (#10197)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SharkyBytes SharkyBytes

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Response Issues which require feedback from lead Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed#10197: Removed redundant 'Feedback' button SharkyBytes/openlibrary
2 participants
@RayBB @SharkyBytes