-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate IA identifier on Edition edit #109
Comments
We need to go farther than just validating IDs. Changing an archive.org id, even to another valid one, can break lending and other things. We need to make archive.org IDs only editable by admins. Also, the Lending Library, In Library, and Protected Daisy subjects need to protected in the same way. |
This is still broken. Here's a recent example where someone added a full URL instead of just the ID: http://openlibrary.org/books/OL25424185M/The_Lunar_Basis_of_Myth_and_Symbol/edit Apparently the IDs can be added (without validation), but not deleted or edited. Attempting to add a second IA ID fails silently with no error message. |
we've disabled editing Internet Archive ID to avoid the ill effects of it. I'll work on validating it. |
This problem still persists after five years. The IA identifier is not validated before first creating an edition record, nor is it checked for uniqueness and as having an extant IA target. Example: |
thank you for bumping this (cc: @bfalling). @LeadSongDog, we're going to start doing community calls bi-weekly (we're still converging on a date/time -- those interested can vote here: http://doodle.com/poll/hrqphgaw2k9zhfbsyeuis638/admin#table). We'd love you to join us if this aligns with your style, and alternatively, if you prefer, we invite you to submit an update prior to our meeting so we can represent the issues and features which are most important to you. As per this issue, I'm hearing what you're saying -- I think it's worth discussing strategies for addressing this, whether it is through something like an edition merge (which is an available feature for admins) and whether we write some script to identify duplicates like the one you uncovered, or whether we build a check into the EDIT feature for an edition (i.e. we check against the API prior to approving the archive id). I am going to defer to @bfalling for the prioritization. Right now we're working to fix our bookserver/opds service (as it stopped working when we decommissioned SOLR in favor of ES). @LeadSongDog, thank you for your continued passion and contributions! |
Is this Issue done @mekarpeles ? |
Still no one assigned, and still broken.
|
@bfalling was tagged for prioritization a year and a bit ago. Through what channel does he communicate IA's priority (at least I assume IA is what he's in charge of communicating priority for). Will he do that through the Tuesday development team meetings or some other channel? |
TL;DR -- issue still open. @tfmorris, brenton's invited to join us on Tuesday so we can all make cases for the issues/features we feel are important. He and I will likely have a followup mtg later this week (Friday) w/ internal stakeholders to see if there are separate needs which require addressing. Next Tuesday (March 20) I'll hopefully have a Q2 github project board organized and we'll entertain a final round of community feedback so we can make sure everyone's feedback has been incorporated. As per this specific issue, we do still have The case of |
It's unclear what resolution means in this context, let's please create another issue to address specific cases e.g. validate ocaid on edit or create. |
George had three very specific requests for the Edit Edition form. I don't know what she thinks, but I'd consider this resolved when those were done. They all sound like good ideas to me. If people want to 1+ things, sure, they should create new issues. The more general issue of "Accept a full URL anyplace an identifier can be entered" deserves a separate issue for the cases other than OCAIDs on the Edit Edition page. I've created #866 for this. |
It's important that only real IA identifiers are entered on the Edit Edition form.
We should also accept full URLs as identifiers in that form, I think. For other types of IDs.
The text was updated successfully, but these errors were encountered: