OCAID and ISBN validation #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
helps prevent #467 |
|
LGTM |
|
Validation of an identifier takes more than checking it has the correct form. It needs to be tested in a query to determine if the target record exists and is accessible. #109 exemplifies the problem. Further, when an identified remote record is perishable there should either be a persistent way of archiving it (wayback for URLs, perhaps?) or a redirect mechanism in place (as for OCLCn redirections) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could extend the whitespace check to catch whitespace in any other id.
ISBN check is very basic, only looks for string length. It means dashes in ISBNs will no longer be accepted.