Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes in the editions component for tablets #2006

Open
koderjoker opened this issue Mar 24, 2019 · 4 comments
Open

Make changes in the editions component for tablets #2006

koderjoker opened this issue Mar 24, 2019 · 4 comments
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]

Comments

@koderjoker
Copy link
Contributor

koderjoker commented Mar 24, 2019

Page: http://openlibrary.org/works/OL15203543W/Meistersinger_von_N%C3%BCrnberg

Is your feature request related to a problem? Please describe.

Continuation of #1339. For screen widths <=789px and >500px the read ebook button is far too wide, further changes in the editions component are required.
0 0 0 0_8080_works_OL15203543W_Meistersinger_von_N%C3%BCrnberg(iPad)

Proposal & Constraints

Some previous discussions to start off from:


Originally posted by @tfmorris in #1899(comment)

Did reducing with width of the "Read" button get lost? I commented on it a few weeks ago and @koderjoker said:

For starters, the width of the 'read eBook button' definitely needs to be reduced. We then could have the 'daisy and download links' on one line and the 'library and purchasing links' on another, but the read ebook button would still have space left over on the side...

which sounded like agreement that it was too wide. Paradoxically, it's fine when the screen is wide, but below ~770 pix, it jumps to full width.


Originally posted by @koderjoker in #1899(comment)

Shifting download links to a dropdown (to overcome problem of whitespace and make download links bigger for mobile)
Rough visualisation
download button


Originally posted by @koderjoker in #1899(comment)

For tablet
screen shot 2019-03-01 at 10 31 58 pm

Unfortunately, the tablet version still needs changes :p

For starters, the width of the 'read eBook button' definitely needs to be reduced. We then could have the 'daisy and download links' on one line and the 'library and purchasing links' on another, but the read ebook button would still have space left over on the side...

We could overcome that with a future download button though. The 'read ebook and download button' on one line, and 'library links and purchase links' on another.


However, the above would require deciding on a design for a dropdown.

@brad2014 brad2014 added the Affects: UI Issues with the web site's user interface. [managed] label Jun 6, 2019
@jdlrobson jdlrobson added the Priority: 3 Issues that we can consider at our leisure. [managed] label Aug 1, 2019
@xayhewalo xayhewalo added State: Backlogged Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed] labels Nov 19, 2019
@jdlrobson
Copy link
Collaborator

Maybe we want to expand this issue to be a redesign given the comments by @BrittanyBunk in #679 (comment)

@SaravgiYash
Copy link
Contributor

SaravgiYash commented Jan 13, 2021

@jdlrobson I would like to work on this issue.
Currently only Download for print-disabled is present and in another issue, I have added Worldcat link.
So in this issue, I just have to reduce the Borrow button width?

My suggestion: We can keep the desktop design till width: 568px this will solve the issue.
image

@jdlrobson
Copy link
Collaborator

This is mostly fixed.

Help fixing the size of the buttons on https://openlibrary.org/works/OL15203543W/Meistersinger_von_N%C3%BCrnberg here to be the width of the label is all that's needed to resolve this now:

Screen Shot 2021-01-13 at 6 04 34 PM

Help fixing that appreciated! Feel free!

The buttons in the screenshot below are fine and working as expected

image

@jdlrobson jdlrobson added the Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] label Jan 14, 2021
Copy link

Assignees removed automatically after 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

6 participants