Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Open Library Fully Mobile Responsive #679

Closed
5 tasks
mekarpeles opened this issue Dec 18, 2017 · 15 comments · Fixed by #1731
Closed
5 tasks

Make Open Library Fully Mobile Responsive #679

mekarpeles opened this issue Dec 18, 2017 · 15 comments · Fixed by #1731
Assignees
Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Dec 18, 2017

Currently, the homepage is the only page which is fully mobile responsive. We accomplish this within the plugin/openlibary/home.py view by injecting v2 as an attribute into the page template after it is rendered and then by changing the templates/site.html content based on whether the page has this v2 attribute to conditionally include a viewport metatag as well as other necessary changes.

This issue concerns (is the parent for) all changes towards mobile responsiveness on Openlibrary.org

How do we get there?

@mekarpeles
Copy link
Member Author

cc: @html5cat

@html5cat
Copy link
Contributor

@mekarpeles could you outline the key pages and relevant files that are highest priority? Any relevant tips/tricks appreciated too!

@vigneshtdev
Copy link

Hi I would like to help out with this.

@mekarpeles
Copy link
Member Author

mekarpeles commented Mar 20, 2018

Hi @vigneshtdev! As a first step, I think we should prioritize the /search page because it's relatively high traffic and there aren't that many "moving parts".

The goal would be (in the mobile view) to take everything that is currently displayed under the Zoom In facet sidebar and turn it into a drop down menu which can be triggered by something like a filter icon. With the sidebar moved under the dropdown in the mobile view, the books would be able to take up 100% of the width.

@mekarpeles mekarpeles added the Theme: Accessibility Work related to disability accessibility. [managed] label Mar 20, 2018
@mekarpeles
Copy link
Member Author

mekarpeles commented May 19, 2018

@vigneshtdev we'd love your help if you're still open to trying this :)

Let us know and we'll be happy to invite you to our slack channel

@vigneshtdev
Copy link

yeah sure, your guidance will be very helpful. :)

@mekarpeles
Copy link
Member Author

mekarpeles commented May 19, 2018

@vigneshtdev, I'm happy to help! Ask away. Have you had a chance to get a developer environment setup yet?

If you send me a message to mek@archive.org, we'll be happy to add you to our community slack channel.

@vigneshtdev
Copy link

I have indeed set up a dev environment. As you pointed out before that first we ought to focus on /serach pages so the current state on an iPhone is:

localhost_8080_search iphone 5_se

So what are major changes you think should be implemented to make it more responsive?

@mekarpeles
Copy link
Member Author

mekarpeles commented May 20, 2018

Thanks! If you make a search, you'll notice the search results interface looks like:

current-search-desktop

I imagine we want something a bit closer to:
search-mobile

@psyked
Copy link
Contributor

psyked commented Jun 29, 2018

I've started some work towards this on a branch: https://github.com/psyked/openlibrary/tree/679/feature/fully-responsive-design

For the most part, it's a case of replacing any hardcoded element widths with fluid versions or max-width versions, but there are some elements, such as the carousels, which will require a little more effort.

@jdlrobson jdlrobson added the Type: Epic A feature or refactor that is big enough to require subissues. [managed] label Nov 4, 2018
@jdlrobson jdlrobson self-assigned this Nov 14, 2018
jdlrobson added a commit to jdlrobson/openlibrary that referenced this issue Dec 15, 2018
Maintaining both v2 and v1 is becoming a bit of a burden
and resulting in various issues (such as analytics code which
expects a more modern version of jQuery).

I'm pretty confident at this point that we can deploy the
"nuclear" option and make v2 the default.

v2 boolean flags are left in tact as I'm not sure if they serve
any other purposes (for example in API requests)

"Mr President, it is not only possible, it is essential."
Dr Strangelove or: How I learned to stop worrying about making
Open Library mobile friendly

While this makes Open Library fully responsive, there are lots of
opportunities to improve the UI further in mobile.. there's a long
road ahead!

Untested but should also fix: internetarchive#1728 internetarchive#1727

Fixes: internetarchive#679
jdlrobson added a commit to jdlrobson/openlibrary that referenced this issue Dec 15, 2018
Maintaining both v2 and v1 is becoming a bit of a burden
and resulting in various issues (such as analytics code which
expects a more modern version of jQuery).

I'm pretty confident at this point that we can deploy the
"nuclear" option and make v2 the default.

v2 boolean flags are left in tact as I'm not sure if they serve
any other purposes (for example in API requests)

"Mr President, it is not only possible, it is essential."
Dr Strangelove or: How I learned to stop worrying about making
Open Library mobile friendly

While this makes Open Library fully responsive, there are lots of
opportunities to improve the UI further in mobile.. there's a long
road ahead!

Untested but should also fix: internetarchive#1728 internetarchive#1727

Fixes: internetarchive#679
jdlrobson added a commit to jdlrobson/openlibrary that referenced this issue Dec 15, 2018
Maintaining both v2 and v1 is becoming a bit of a burden
and resulting in various issues (such as analytics code which
expects a more modern version of jQuery).

I'm pretty confident at this point that we can deploy the
"nuclear" option and make v2 the default.

v2 boolean flags are left in tact as I'm not sure if they serve
any other purposes (for example in API requests)

"Mr President, it is not only possible, it is essential."
Dr Strangelove or: How I learned to stop worrying about making
Open Library mobile friendly

While this makes Open Library fully responsive, there are lots of
opportunities to improve the UI further in mobile.. there's a long
road ahead!

Untested but should also fix: internetarchive#1728 internetarchive#1727

Fixes: internetarchive#679
@jdlrobson
Copy link
Collaborator

Hurraahhhh

@jdlrobson
Copy link
Collaborator

I'll cut open more specific tasks as there are still likely to be many problems with mobile friendliness!

@brad2014 brad2014 added the Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] label May 4, 2019
@BrittanyBunk
Copy link
Contributor

Do we have specific #'s on this? I only see #685.

@BrittanyBunk
Copy link
Contributor

One of the issues (I don't see it posed, but correct me if I'm wrong) is that the editions table in works is really bad. I needs:

  • better breaks between editions
  • simplified boxes: 1) the read button could be smaller, as I feel people do want to listen more than read and the read button's crowding out finding the listen button, 2) I think we could simplify it to just the year for the wording (image is too small to see, the title's the same - so just repeat - waste of space, publisher - not really important enough to show). Let's take out "libraries near you" and say "nearby: WorldCat", "buy: betterworldbooks". I think it is important for people to find a book nearby in a library or buy it on their phone, so that's good. I just think it goes below the 'read/audio' part.

image

@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Dec 22, 2019

there's more (including the IA), but we'll start there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] Theme: Accessibility Work related to disability accessibility. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants