-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Open Library Fully Mobile Responsive #679
Comments
cc: @html5cat |
@mekarpeles could you outline the key pages and relevant files that are highest priority? Any relevant tips/tricks appreciated too! |
Hi I would like to help out with this. |
Hi @vigneshtdev! As a first step, I think we should prioritize the /search page because it's relatively high traffic and there aren't that many "moving parts". The goal would be (in the mobile view) to take everything that is currently displayed under the Zoom In facet sidebar and turn it into a drop down menu which can be triggered by something like a filter icon. With the sidebar moved under the dropdown in the mobile view, the books would be able to take up 100% of the width. |
@vigneshtdev we'd love your help if you're still open to trying this :) Let us know and we'll be happy to invite you to our slack channel |
yeah sure, your guidance will be very helpful. :) |
@vigneshtdev, I'm happy to help! Ask away. Have you had a chance to get a developer environment setup yet? If you send me a message to mek@archive.org, we'll be happy to add you to our community slack channel. |
I've started some work towards this on a branch: https://github.com/psyked/openlibrary/tree/679/feature/fully-responsive-design For the most part, it's a case of replacing any hardcoded element widths with fluid versions or max-width versions, but there are some elements, such as the carousels, which will require a little more effort. |
Maintaining both v2 and v1 is becoming a bit of a burden and resulting in various issues (such as analytics code which expects a more modern version of jQuery). I'm pretty confident at this point that we can deploy the "nuclear" option and make v2 the default. v2 boolean flags are left in tact as I'm not sure if they serve any other purposes (for example in API requests) "Mr President, it is not only possible, it is essential." Dr Strangelove or: How I learned to stop worrying about making Open Library mobile friendly While this makes Open Library fully responsive, there are lots of opportunities to improve the UI further in mobile.. there's a long road ahead! Untested but should also fix: internetarchive#1728 internetarchive#1727 Fixes: internetarchive#679
Maintaining both v2 and v1 is becoming a bit of a burden and resulting in various issues (such as analytics code which expects a more modern version of jQuery). I'm pretty confident at this point that we can deploy the "nuclear" option and make v2 the default. v2 boolean flags are left in tact as I'm not sure if they serve any other purposes (for example in API requests) "Mr President, it is not only possible, it is essential." Dr Strangelove or: How I learned to stop worrying about making Open Library mobile friendly While this makes Open Library fully responsive, there are lots of opportunities to improve the UI further in mobile.. there's a long road ahead! Untested but should also fix: internetarchive#1728 internetarchive#1727 Fixes: internetarchive#679
Maintaining both v2 and v1 is becoming a bit of a burden and resulting in various issues (such as analytics code which expects a more modern version of jQuery). I'm pretty confident at this point that we can deploy the "nuclear" option and make v2 the default. v2 boolean flags are left in tact as I'm not sure if they serve any other purposes (for example in API requests) "Mr President, it is not only possible, it is essential." Dr Strangelove or: How I learned to stop worrying about making Open Library mobile friendly While this makes Open Library fully responsive, there are lots of opportunities to improve the UI further in mobile.. there's a long road ahead! Untested but should also fix: internetarchive#1728 internetarchive#1727 Fixes: internetarchive#679
Hurraahhhh |
I'll cut open more specific tasks as there are still likely to be many problems with mobile friendliness! |
Do we have specific #'s on this? I only see #685. |
One of the issues (I don't see it posed, but correct me if I'm wrong) is that the editions table in works is really bad. I needs:
|
there's more (including the IA), but we'll start there. |
Currently, the homepage is the only page which is fully mobile responsive. We accomplish this within the plugin/openlibary/home.py view by injecting
v2
as an attribute into the page template after it is rendered and then by changing the templates/site.html content based on whether the page has thisv2
attribute to conditionally include a viewport metatag as well as other necessary changes.This issue concerns (is the parent for) all changes towards mobile responsiveness on Openlibrary.org
How do we get there?
The text was updated successfully, but these errors were encountered: