Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCCN incorrectly imported when containing alpha characters #2851

Closed
tfmorris opened this issue Jan 13, 2020 · 1 comment · Fixed by #2865
Closed

LCCN incorrectly imported when containing alpha characters #2851

tfmorris opened this issue Jan 13, 2020 · 1 comment · Fixed by #2865
Assignees
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] Theme: MARC records Type: Bug Something isn't working. [managed]

Comments

@tfmorris
Copy link
Contributor

Significant, non-numeric, characters are being dropped from LCCNs on import from MARC records. This is a long standing bug, so perhaps this is a duplicate report, but I can't find it in the current bug tracker. Perhaps it's in one of the previous trackers and didn't get transferred.

As an example, this MARC 010$a field

010 $aa 47003377

got imported here as 47003377 instead of a47003377.

These leading alpha prefixes are significant for LCCNs, so must be preserved.

Note that https://lccn.loc.gov/a%2047003377 doesn't resolve, so we need to either strip spaces when constructing the URL.

The full structure of the LCCN is described here: https://www.loc.gov/marc/lccn_structure.html

Stakeholders

@hornc

Not a showstopper, but should be fixed before doing any more MARC imports.

@tfmorris tfmorris added Type: Bug Something isn't working. [managed] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] State: Backlogged Affects: Data Issues that affect book/author metadata or user/account data. [managed] labels Jan 13, 2020
@hornc hornc added Theme: MARC records Priority: 2 Important, as time permits. [managed] labels Jan 13, 2020
@hornc hornc self-assigned this Jan 13, 2020
@hornc
Copy link
Collaborator

hornc commented Jan 13, 2020

Thanks for adding this issue @tfmorris -- I wasn't aware of this unfortunately, it shouldn't be broken and I want to fix it ASAP!

@hornc hornc added this to the Active Sprint milestone Jan 13, 2020
@xayhewalo xayhewalo added Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @hornc Issues overseen by Charles (Staff: Data Engineering Lead) [managed] Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] Theme: MARC records Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants