Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commands fail for %Developer user if git not on path #444

Closed
isc-pbarton opened this issue Aug 1, 2024 · 1 comment · Fixed by #460
Closed

Git commands fail for %Developer user if git not on path #444

isc-pbarton opened this issue Aug 1, 2024 · 1 comment · Fixed by #460
Assignees
Labels
bug Something isn't working

Comments

@isc-pbarton
Copy link
Collaborator

isc-pbarton commented Aug 1, 2024

If "git" is not on the path, and instead the full path to git is specified through git-source-control configuration, all git commands will fail for a user with just the %Developer role with a NOTOPEN.

The reason is that the "git bin path" configuration setting is stored in a global in the %SYS namespace, so you need access to that global. A %Developer will get a PROTECT error trying to access it.

@isc-pbarton isc-pbarton added the bug Something isn't working label Aug 1, 2024
@isc-pbarton
Copy link
Collaborator Author

Fix will be:
Change SYSNamespaceStorage to use ^%SYS instead of ^["%SYS"]SYS
Add an installation step that will migrate settings from the old global to the new global

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants