resolved issue with instance wide settings being in protected global #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-pbarton
requested changes
Aug 15, 2024
cls/SourceControl/Git/Utils.cls
Outdated
| @@ -183,6 +183,13 @@ ClassMethod IsImportAfter(menuItemName As %String) As %Boolean [ CodeMode = expr | |||
| $Find(..#ImportAfterGitMenuItems, ","_menuItemName_",") > 0 | |||
| } | |||
|
|
|||
| ClassMethod MigrateInstanceSettings() | |||
| { | |||
| if '$data(@..%SYSNamespaceStorage()@("%gitBinPath")) { | |||
There was a problem hiding this comment.
If there is no gitBinPath configured on the system, this will run every time git-source-control is installed, which could lead to weird behavior. I think instead we should check if any subscripts are defined in the old global (not just "%gitBinPath"). If yes, then we merge the old global to the new and kill the old global.
isc-pbarton
requested changes
Aug 15, 2024
isc-tleavitt
approved these changes
Aug 16, 2024
isc-pbarton
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444