-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress deletion in locked environment #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks great. I would say that the SourceControl.Git.TestDelete class should be deleted entirely, since its only purpose is for manual testing of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update CHANGELOG.md with a note about this in the "Fixed" section
…ontrol into suppressDelete
This fixes #302 |
Testing Steps:
(enter passcode for deploy key if prompted)
In IRIS terminal
2. Load git-source-control repository into IRIS from the community package registry.
If you see "Dubious Ownership" error in Output window, you have to change owner of local git-source-control repo. Steps to do that on Windows:
a.
$objSID = New-Object System.Security.Principal.SecurityIdentifier("<SID>")
Note: replace <SID> with <SID> in "the current user is: '<SID>'" part of dubious ownership error message
b.
$objUser = $objSID.Translate([System.Security.Principal.NTAccount])
c.
icacls <path to local git-source-control repo cloned in step 1> /setowner $objUser.value /T
Note: replace <path to local git-source-control repo cloned in step 1> with a path like C:\Users<your username>\
In VS Code,
10. Click the ObjectScript icon in the left side menu to open ObjectScript Explorer window, click "Choose Server and Namespace" and sign in using InterSystems Server Credentials.
11. Open an InterSystems Websocket Terminal.
12. Verify that you are still in locked environment
should print 1
13. In ObjectScript Explorer window, click Classes > SourceControl > Git > TestDelete.cls
14. Right-click on TestDelete and then click "Delete" > "Confirm". Verify that TestDelete file wasn't deleted.