disallows the user from choosing the add menu option on an uncompiled file #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-tleavitt
requested changes
Jul 11, 2024
isc-tleavitt
previously requested changes
Jul 12, 2024
There was a problem hiding this comment.
Thinking about this more, a few things I'd like to test:
What do we currently do if you try to add a whole package to source control? Will this break it? What about multiple selection of items? Does this work in VSCode or just Studio?
Also would be great if we could clean up the itemName parsing a little bit to make it more readable; Pravin pointed to Type() for this.
isc-pbarton
reviewed
Jul 18, 2024
isc-pbarton
approved these changes
Jul 18, 2024
isc-pbarton
dismissed
isc-tleavitt’s stale review
Henry refactored to use Type() and tested adding a whole package to source control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405