Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors on deleting items with nonexistent files #576

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

isc-etamarch
Copy link
Collaborator

Fix #524

@isc-etamarch isc-etamarch linked an issue Oct 24, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 25.97%. Comparing base (7bbcfd1) to head (40258d4).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ceControl/Git/PullEventHandler/IncrementalLoad.cls 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   25.94%   25.97%   +0.02%     
==========================================
  Files          18       18              
  Lines        2713     2745      +32     
==========================================
+ Hits          704      713       +9     
- Misses       2009     2032      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isc-tleavitt isc-tleavitt merged commit 390bfd3 into main Oct 24, 2024
2 checks passed
@isc-tleavitt isc-tleavitt deleted the 524-deleting-deleted-files-on-import-all-fails branch October 24, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting deleted files on Import All fails
3 participants