fix: transaction onComplete error to be reported only if error is not…

… null (#80) * fix: log error to console only if error is not null * updated package version
interviewstreet · Nov 30, 2023 · c5fa9a1 · c5fa9a1
1 parent fc3b4cc
commit c5fa9a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@hackerrank/firepad",
   "description": "Collaborative text editing powered by Firebase",
-  "version": "0.8.3-beta",
+  "version": "0.8.4-beta",
   "author": {
     "email": "bprogyan@gmail.com",
     "name": "Progyan Bhattacharya",

diff --git a/src/firebase-adapter.ts b/src/firebase-adapter.ts
@@ -497,9 +497,9 @@ export class FirebaseAdapter implements IDatabaseAdapter {
             }
           },
           (error, committed) => {
-            console.error("[firebase] Transaction error - onComplete", error);
-
             if (error) {
+              console.error("[firebase] Transaction error - onComplete", error);
+
               if (error.message === "disconnect") {
                 if (this._sent && this._sent.id === revisionId) {
                   // We haven't seen our transaction succeed or fail.  Send it again.