Add scope to documentation #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davidhuser
reviewed
Oct 16, 2023
|
just did a quick scan, I think it misses setting the default scope during FastAPI.app instantiation, see bottom part here #106 (comment) |
davidhuser
reviewed
Oct 16, 2023
| @@ -185,23 +185,46 @@ We've used two flags: `usePkceWithAuthorizationCodeGrant`, which is the authenti | |||
|
|
|||
| Now, the fun part begins! 🚀 | |||
|
|
|||
| Import the `SingleTenantAzureAuthorizationCodeBearer` from `fastapi_azure_auth` and configure it: | |||
| Import the `SingleTenantAzureAuthorizationCodeBearer` from `fastapi_azure_auth` and configure it. You can use the `Settings` class to compute the required URLs: | |||
There was a problem hiding this comment.
nitpick but we also compute other properties, so maybe "... compute the required fields"
davidhuser
reviewed
Oct 16, 2023
| f'api://{settings.APP_CLIENT_ID}/user_impersonation': 'user_impersonation', | ||
| } | ||
| scopes=settings.SCOPES, | ||
| openapi_authorization_url=settings.OPENAPI_AUTHORIZATION_URL, |
There was a problem hiding this comment.
These are new params added to SingleTenant not previously in the docs. I don't have much experience with Single Tenant and would refer to @JonasKs
There was a problem hiding this comment.
Yeah, these should be default 99% of the time. No reason to confuse with these params. 😊
If they are required for the padlock I'd say we use the azure_schemes URL in the docs instead.
|
Thank you so much 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for the mess! I've somehow managed to destroy my previous PR #106 and have created this one to fix the history problems. Sorry for the chaos. :(
I would appreciate if you could add the HACKTOBERFEST-ACCEPTED label to the pull request.