Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isPlainObject incorrectly identifies objects wrapped in a Proxy object in Safari 10 #1379

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: isPlainObject incorrectly identifies objects wrapped in a Proxy object in Safari 10 #1379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/shared/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,11 @@ export const objectToString = Object.prototype.toString
export const toTypeString = (value: unknown): string =>
objectToString.call(value)

export const isPlainObject = (val: unknown): val is object =>
toTypeString(val) === '[object Object]'
export const isPlainObject = (val: unknown): val is object => {
if (!isObject(val)) return false
const proto = Object.getPrototypeOf(val)
return proto === null || proto.constructor === Object
}

// for converting list and named values to displayed strings.
export const toDisplayString = (val: unknown): string => {
Expand Down